Attention is currently required from: pespin, fixeria.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32217 )
Change subject: bsc: add TC_mscpool_sccp_n_pcstate_attaches_msc ......................................................................
Patch Set 1:
(2 comments)
File bsc/BSC_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32217/comment/753a351e_7b6d5... PS1, Line 9190: pars1.mscpool.l3_info := valueof(ts_LU_REQ(LU_Type_IMSI_Attach, valueof(ts_MI_IMSI_LV('001010420000001'H)), '00F110'O));
ok, so why is the IMSI being changed in this commit?
it is a rebase artifact and should not be here, thx.
Marking changes in a line: ack, that would be very bad if that stopped working in general? it's a pivotal part of code review.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32217/comment/1fc2671a_9e5d1... PS1, Line 9211: pars3.mscpool.l3_info := valueof(ts_PAG_RESP(valueof(ts_MI_IMSI_LV('001010420000003'H))));
full ACK
meh ok, all this overhead only for nice looks, but yea