Attention is currently required from: fixeria.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/36323?usp=email )
Change subject: common: Add RTP related rate counters
......................................................................
Patch Set 1:
(1 comment)
File src/common/bts.c:
https://gerrit.osmocom.org/c/osmo-bts/+/36323/comment/8de35587_3119a498
PS1, Line 110: received
cosmetic: maybe say 'incoming RTP packets'?
[…]
I don't see anything wrong with the language, sorry. The packets were
received by our program (using recvfrom, which has an abbreviated "received" in
the name), and then subsequently dropped in the preening code. I'm not saying
_forwarded_ or _processed_ packets, but just received. Also the counter is named rx (for
received), like we usually do
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/36323?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ide674bde10b0e4b501d6a48947b983090342dfec
Gerrit-Change-Number: 36323
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 18 Mar 2024 09:10:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment