18 Nov
2024
18 Nov
'24
8:33 p.m.
Attention is currently required from: laforge, pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38806?usp=email )
Change subject: ipaccess: Simplify code after early return if block ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
Oh yes, in this code, every small step towards clarification helps in not falling below a big rock g […]
It's two unrelated if-blocks, so IMO the patch makes it cleaner. CR+2 from me.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38806?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I406b4f4e973c9b75b102aea3d6fe6aab73d91185
Gerrit-Change-Number: 38806
Gerrit-PatchSet: 1
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Mon, 18 Nov 2024 19:33:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge laforge@osmocom.org
Comment-In-Reply-To: pespin pespin@sysmocom.de