21 Oct
2024
21 Oct
'24
8:10 p.m.
Jenkins Builder has posted comments on this change by lynxis lazus. (
https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email )
Change subject: vlr: add PS support
......................................................................
Patch Set 1:
(3 comments)
File src/libvlr/vlr_lu_fsm.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19334):
https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/65a3a0e5_eede9c6e?usp… :
PS1, Line 575: static int lu_compl_vlr_timeout(struct osmo_fsm_inst *fi) {
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19334):
https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/00981ee8_5a6e83cc?usp… :
PS1, Line 588: LOGPFSML(fi, LOGL_ERROR, "LU Compl timeout %i / %i \n",
fi->T, lcvp->N);
unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19334):
https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/ec7fd840_c7dc1334?usp… :
PS1, Line 588: LOGPFSML(fi, LOGL_ERROR, "LU Compl timeout %i / %i \n",
fi->T, lcvp->N);
Use %d instead of %i
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ie9ffeb140c9d354b3a0f4822e2619f623235add0
Gerrit-Change-Number: 38490
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Mon, 21 Oct 2024 18:10:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No