30 Jan
2026
30 Jan
'26
8:21 p.m.
Attention is currently required from: laforge, pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41971?usp=email )
Change subject: logging_file: Clean log_target_file_reopen() ......................................................................
Patch Set 7: Code-Review+1
(1 comment)
Patchset:
PS3:
A switch statement on what variable exactly?
Ah, I overlooked that the if-else was not based on `target->type`. Disregard my comment then.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41971?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibcb50320ad80b034115cccc3b7ab90501ac1d091
Gerrit-Change-Number: 41971
Gerrit-PatchSet: 7
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-CC: laforge laforge@osmocom.org
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Fri, 30 Jan 2026 19:21:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge laforge@osmocom.org
Comment-In-Reply-To: pespin pespin@sysmocom.de
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de