Attention is currently required from: jolly, laforge.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/32934 )
Change subject: Add support for receiving Bter UI frames at lapdm.c
......................................................................
Patch Set 1:
(2 comments)
File src/gsm/lapdm.c:
https://gerrit.osmocom.org/c/libosmocore/+/32934/comment/50189c46_e2c1b3dd
PS1, Line 841: /* FIXME */
explicit /* fall-through */ should be added to clarify
this is not an accident. […]
Ack
https://gerrit.osmocom.org/c/libosmocore/+/32934/comment/181445c4_5e1257fe
PS1, Line 735: /* If UI on SACCH sent by BTS, lapdm_fmt must be B4 */
please don't breake the else if like this, the if-else sequence in here is already
complex enough to follow. Feel free to move the comment to the side, or move the else
below the comment.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/32934
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If04115884743455c7bf2b2bc5f7e49e74b6ffb60
Gerrit-Change-Number: 32934
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 23 May 2023 15:28:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment