Attention is currently required from: jolly, laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32934 )
Change subject: Add support for receiving Bter UI frames at lapdm.c ......................................................................
Patch Set 1:
(2 comments)
File src/gsm/lapdm.c:
https://gerrit.osmocom.org/c/libosmocore/+/32934/comment/50189c46_e2c1b3dd PS1, Line 841: /* FIXME */
explicit /* fall-through */ should be added to clarify this is not an accident. […]
Ack
https://gerrit.osmocom.org/c/libosmocore/+/32934/comment/181445c4_5e1257fe PS1, Line 735: /* If UI on SACCH sent by BTS, lapdm_fmt must be B4 */ please don't breake the else if like this, the if-else sequence in here is already complex enough to follow. Feel free to move the comment to the side, or move the else below the comment.