Attention is currently required from: jolly, laforge.
View Change
2 comments:
File src/gsm/lapdm.c:
Patch Set #1, Line 841: /* FIXME */
explicit /* fall-through */ should be added to clarify this is not an accident. […]
Ack
Patch Set #1, Line 735: /* If UI on SACCH sent by BTS, lapdm_fmt must be B4 */
please don't breake the else if like this, the if-else sequence in here is already complex enough to follow. Feel free to move the comment to the side, or move the else below the comment.
To view, visit change 32934. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If04115884743455c7bf2b2bc5f7e49e74b6ffb60
Gerrit-Change-Number: 32934
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas@eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge@osmocom.org>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: jolly <andreas@eversberg.eu>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Comment-Date: Tue, 23 May 2023 15:28:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge@osmocom.org>
Gerrit-MessageType: comment