Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29695 )
Change subject: msc_a,vlr: add ciphering_required (accurately named) ......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1: Did you think about
File src/libvlr/vlr_access_req_fsm.c:
https://gerrit.osmocom.org/c/osmo-msc/+/29695/comment/66f0fe9d_3aafa16c PS1, Line 662: par->try_ciphering = try_ciphering; did you think about adding a check for "(!try_ciphering && ciphering_required)" ? Because if you get that here it already means something is wrong in config and can be rejected?