Attention is currently required from: laforge, lynxis lazus.
pespin has posted comments on this change by lynxis lazus. (
https://gerrit.osmocom.org/c/libosmocore/+/39557?usp=email )
Change subject: gprs: define OSMO_RESERVED_RAC 0xff
......................................................................
Patch Set 1:
(1 comment)
File include/osmocom/gsm/protocol/gsm_04_08_gprs.h:
https://gerrit.osmocom.org/c/libosmocore/+/39557/comment/29623828_391ca609?… :
PS1, Line 14: #define OSMO_RESERVED_RAC 0xff
so basically pespins point would be to mark it
GSM*_RESERVED_RAC instead of OSMO_RESERVED_RAC. […]
I'm actually more
concerned about the comment in line 11 stating "osmocom specific". Having
whatever defined prefixed as OSMO_ is fine (regardless of it being osmocom specific or
not, simply for C namespacing..)
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/39557?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I17a2adedc2c2ab158f40d58280f5df5c6967b8ec
Gerrit-Change-Number: 39557
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Tue, 25 Feb 2025 12:44:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>