Jenkins Builder has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-hlr/+/32511 )
Change subject: hlr: use talloc for memory allocation in
osmo_gsup_create_insert_subscriber_data_msg
......................................................................
Patch Set 1:
(2 comments)
File src/hlr.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-6548):
https://gerrit.osmocom.org/c/osmo-hlr/+/32511/comment/9ae3769d_0c840646
PS1, Line 162: cont_err:
labels should not be indented
File src/lu_fsm.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-6548):
https://gerrit.osmocom.org/c/osmo-hlr/+/32511/comment/051d3cd9_32426c75
PS1, Line 248: lu->is_ps? OSMO_GSUP_CN_DOMAIN_PS : OSMO_GSUP_CN_DOMAIN_CS,
spaces required around that '?' (ctx:VxW)
--
To view, visit
https://gerrit.osmocom.org/c/osmo-hlr/+/32511
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I00b5c2dfadcf6e0740e93b4c3292d2654d22e80c
Gerrit-Change-Number: 32511
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Wed, 26 Apr 2023 17:40:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment