Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40813?usp=email )
Change subject: Re-introduce Iu/UTRAN support ......................................................................
Patch Set 2:
(4 comments)
File src/sgsn/gprs_routing_area.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/40813/comment/61e2041c_dfc78cb7?usp... : PS2, Line 439: } else { You can move this code path above as an early return.
https://gerrit.osmocom.org/c/osmo-sgsn/+/40813/comment/474fcc2c_c57d039b?usp... : PS2, Line 483: else if (mmctx->p_tmsi_old != GSM_RESERVED_TMSI) these "else" here and below are not needed since you are doing early return.
File tests/gprs_routing_area/gprs_routing_area_test.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/40813/comment/ef73e0de_092b9552?usp... : PS2, Line 541: /* check if a GERAN RA/cell with the same LAC as an already register UTRAN gets rejected */ registered?
https://gerrit.osmocom.org/c/osmo-sgsn/+/40813/comment/6c557f6c_b5f73713?usp... : PS2, Line 542: void test_routing_area_mv_utran_geran_reject(void) I think it's worth explaining here that this is an implementation decision we took and that it's not 100% clear whether LACs from different RANs can be supported.