Attention is currently required from: daniel, fixeria, laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35718?usp=email )
Change subject: Convert README to README.md and expand like in other projects
......................................................................
Patch Set 2:
(1 comment)
File README.md:
https://gerrit.osmocom.org/c/osmo-mgw/+/35718/comment/a504d852_2cafe0c9
PS1, Line 9: The OsmoMGW program exposes an MGCP interface towards a MGPC call agent
I am certainly not an expert in English grammar, but I think it should be `an` because `M` in `MGCP` […]
Ack, I remember discussuing and looking at it previously with Daniel and it seems the sound is the one actually marking whether it's "an" or "n", not the letter.
since MGCP is pronunced EM... hence a vowel sound, it should use "an".
--
To view, visit
https://gerrit.osmocom.org/c/osmo-mgw/+/35718?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Id9a78ccc0d10f0e3a9d832ac4c4988cfbb8ddb3c
Gerrit-Change-Number: 35718
Gerrit-PatchSet: 2
Gerrit-Owner: laforge
laforge@osmocom.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel
dwillmann@sysmocom.de
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-CC: pespin
pespin@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: daniel
dwillmann@sysmocom.de
Gerrit-Comment-Date: Sat, 27 Jan 2024 18:32:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge
laforge@osmocom.org
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
Comment-In-Reply-To: daniel
dwillmann@sysmocom.de
Gerrit-MessageType: comment
