Attention is currently required from: neels, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29402 )
Change subject: llc: implement LLC PDU codec based on code from osmo-sgsn.git ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
why aren't you fixing the linter wrarnings?
I explained a few times already... Will do this one more time:
* Acknowledgement vs Acknowledgment - both spellings are technically correct. 3GPP TS 44.064 uses British spelling, the linter suggests the American spelling. In this case I prefer to have the same spelling as in the specs. * const * const - "should" does not mean must. It's a unit test, and I don't really care whether the test vectors end up in RODATA. It would actually be the first time for me using 'const * const', I don't remember anybody strictly requiring this during code review.
None of this is critical. I am not going to spend more time on this.