Attention is currently required from: laforge, fixeria, pespin.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33937 )
Change subject: MME_Tests: add testcase TC_RIM_RAN_INF
......................................................................
Patch Set 5:
(1 comment)
File mme/MME_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33937/comment/a5dc9ea6_944e…
PS4, Line 689: private function f_TC_RIM_RAN_INF_REQ_req_make_rIMInformation(GTP_CellId
geran_gtp_ci, boolean ts)
tbh, I don't like this kind of function where you
return a generic, unqualified template and pass in […]
I just thought I could save a
little bit of code dup here, but I get the point, probably better to have a proper
template qualifier for the return template.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33937
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I22d5aaab64df2824099977fb574afb86a4b7e91f
Gerrit-Change-Number: 33937
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 07 Aug 2023 12:37:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment