Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/34298?usp=email )
Change subject: oml: ipacc: send GPRS Cell attributes based on IPA Object Version
......................................................................
Patch Set 8:
(1 comment)
This change is ready for review.
File src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/34298/comment/e2234813_74dc140c
PS3, Line 262: if (is_osmobts(bts) || cell->mo.ipaccess.obj_version >= 4) {
I'd prefer having an explicit check for nanobts
here, even if it may actually not be needed: […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/34298?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ie0fb3eaf76e1f70e5a19bb088e1674b7e553d32a
Gerrit-Change-Number: 34298
Gerrit-PatchSet: 8
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 23 Sep 2023 11:00:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment