Attention is currently required from: dexter, laforge, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-mgw/+/36360?usp=email )
Change subject: remove osmo_fd from mgcp_create_bind()
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/libosmo-mgcp/mgcp_network.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/36360/comment/13d723a2_73c3fcfb
PS1, Line 1523: returns 0 on success, -1 on ERROR
this needs to be updated: `\returns a file descriptor; negative on error`
--
To view, visit
https://gerrit.osmocom.org/c/osmo-mgw/+/36360?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I4a3b66a14fdfbc867daca0f0a05f694d5e0d7b66
Gerrit-Change-Number: 36360
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 20 Mar 2024 07:27:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment