neels has submitted this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/31704 )
(
7 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: HO Req: include IE Codec List (MSC Preferred)
......................................................................
HO Req: include IE Codec List (MSC Preferred)
This will make the 10 inter-MSC HO tests in MSC_Tests.ttcn pass again.
Related: OS#5529
Change-Id: Ifcf719c5fc9e11749aafbd97bafda7f6f50973ea
---
M src/libmsc/msc_ho.c
1 file changed, 21 insertions(+), 0 deletions(-)
Approvals:
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/libmsc/msc_ho.c b/src/libmsc/msc_ho.c
index 2f25ca8..d156cd0 100644
--- a/src/libmsc/msc_ho.c
+++ b/src/libmsc/msc_ho.c
@@ -380,6 +380,7 @@
struct vlr_subscr *vsub = msc_a_vsub(msc_a);
struct gsm_network *net = msc_a_net(msc_a);
struct gsm0808_channel_type channel_type;
+ struct gsm0808_speech_codec_list scl;
struct gsm_trans *cc_trans = msc_a->cc.active_trans;
struct ran_msg ran_enc_msg = {
.msg_type = RAN_MSG_HANDOVER_REQUEST,
@@ -421,6 +422,14 @@
return;
}
ran_enc_msg.handover_request.geran.channel_type = &channel_type;
+
+ sdp_audio_codecs_to_speech_codec_list(&scl,
&cc_trans->cc.codecs.result.audio_codecs);
+ if (!scl.len) {
+ msc_ho_failed(msc_a, GSM0808_CAUSE_EQUIPMENT_FAILURE, "Failed to compose"
+ " Codec List (MSC Preferred) for Handover Request message\n");
+ return;
+ }
+ ran_enc_msg.handover_request.codec_list_msc_preferred = &scl;
}
gsm0808_cell_id_from_cgi(&ran_enc_msg.handover_request.cell_id_serving,
CELL_IDENT_WHOLE_GLOBAL, &vsub->cgi);
--
To view, visit
https://gerrit.osmocom.org/c/osmo-msc/+/31704
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ifcf719c5fc9e11749aafbd97bafda7f6f50973ea
Gerrit-Change-Number: 31704
Gerrit-PatchSet: 8
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged