Attention is currently required from: jolly.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/34484?usp=email )
Change subject: Refactoring encoding of mobile identity at mobile application
......................................................................
Patch Set 7: Code-Review+1
(2 comments)
Patchset:
PS7:
BTW, this is already the 2nd time we're migrating from old deprecated to a new (not
yet deprecated) API. Let's see how long this new API will last :P
File src/host/layer23/include/osmocom/bb/mobile/gsm48_mm.h:
https://gerrit.osmocom.org/c/osmocom-bb/+/34484/comment/d6b33307_18808dba
PS7, Line 243: gsm48_encode_mi_lv
I am afraid we may end up having a naming conflict with libosmocore some day, since I am
seeing plenty of `gsm48_encode_*` symbols in there. Not blocking, just wanted to point
this out.
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/34484?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I9ff429bd50d718530fdad64a276053a35c8928f2
Gerrit-Change-Number: 34484
Gerrit-PatchSet: 7
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Tue, 26 Sep 2023 14:14:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment