Attention is currently required from: jolly.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34484?usp=email )
Change subject: Refactoring encoding of mobile identity at mobile application ......................................................................
Patch Set 7: Code-Review+1
(2 comments)
Patchset:
PS7: BTW, this is already the 2nd time we're migrating from old deprecated to a new (not yet deprecated) API. Let's see how long this new API will last :P
File src/host/layer23/include/osmocom/bb/mobile/gsm48_mm.h:
https://gerrit.osmocom.org/c/osmocom-bb/+/34484/comment/d6b33307_18808dba PS7, Line 243: gsm48_encode_mi_lv I am afraid we may end up having a naming conflict with libosmocore some day, since I am seeing plenty of `gsm48_encode_*` symbols in there. Not blocking, just wanted to point this out.