Attention is currently required from: Hoernchen.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/30610 )
Change subject: logging: rework the macros
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmocore/+/30610/comment/e1a52a02_dcffc5dd
PS1, Line 9: For some reason
I guess the idea was to avoid function calls?
https://gerrit.osmocom.org/c/libosmocore/+/30610/comment/171ea650_793f1708
PS1, Line 10: one single logging
: func
If we go for this, shouldn't this function be 'static inline' in the header?
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/30610
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I03efa954cb9e991d2c3da4b61b12aac651e0efa2
Gerrit-Change-Number: 30610
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 15 Dec 2022 02:06:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment