neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35422?usp=email )
Change subject: mgcp_client_test: add test_parse_response() ......................................................................
Patch Set 1:
(3 comments)
File tests/mgcp_client/mgcp_client_test.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/35422/comment/30aef3e9_f7c54974 PS1, Line 739: "m=audio 23 RTP/AVP 3\r\n" /* <-- 112 is missing here. Will it still appear? */ (X) (marker from https://gerrit.osmocom.org/c/osmo-mgw/+/34899/5..11/src/libosmo-mgcp-client/... )
https://gerrit.osmocom.org/c/osmo-mgw/+/35422/comment/6279cdb8_2cc7c4e2 PS1, Line 748: { .codec = CODEC_AMR_8000_1, .pt = 112 }, /* <-- yes, it was added to the end. */ (X) (marker from https://gerrit.osmocom.org/c/osmo-mgw/+/34899/5..11/src/libosmo-mgcp-client/... )
File tests/mgcp_client/mgcp_client_test.err:
https://gerrit.osmocom.org/c/osmo-mgw/+/35422/comment/437e6679_f360505b PS1, Line 159: DLMGCP error in MGCP message: 'a=rtpmap:112' has no matching entry in 'm=audio ... 112' (X) (marker from https://gerrit.osmocom.org/c/osmo-mgw/+/34899/5..11/src/libosmo-mgcp-client/... )