[M] Change in osmo-bsc[master]: ctrl: Add penalty time control

Attention is currently required from: matanp. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32498 ) Change subject: ctrl: Add penalty time control ...................................................................... Patch Set 1: (2 comments) File src/osmo-bsc/bts_ctrl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/32498/comment/3e94323f_3ae71af7 PS1, Line 774: cmd->reply = talloc_asprintf(cmd, "%u", (bts->si_common.cell_ro_sel_par.penalty_time * 20) + 20); can you document with a comment in wich units is this? https://gerrit.osmocom.org/c/osmo-bsc/+/32498/comment/1c2f992c_4daa34ea PS1, Line 796: CTRL_CMD_DEFINE(bts_penalty_time, "penalty-time"); this looks really too generic ("bts.penalty-time"). Maybe add some reference to SI and whatever cell_ro_sel_par is? Maybe add a referenece to spec section? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32498 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idfdd54dec72fb5f52eee22df018161d75b8c48c8 Gerrit-Change-Number: 32498 Gerrit-PatchSet: 1 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-Comment-Date: Tue, 25 Apr 2023 20:28:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment