pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795 )
Change subject: mgw_fsm: add MGW support to osmo-hnbgw ......................................................................
Patch Set 13:
(1 comment)
https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795/1/src/osmo-hnbgw/mgw_fsm.c File src/osmo-hnbgw/mgw_fsm.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795/1/src/osmo-hnbgw/mgw_fsm.c@4... PS1, Line 420: .in_event_mask = S(MGW_EV_MGCP_OK) | S(MGW_EV_MGCP_FAIL),
If you give me an example from somewhere in the osmocom codebase I can replicate the coding style.
Something like: osmo-bsc.git: ./src/osmo-bsc/nm_bts_fsm.c osmo-bsc.git: ./src/osmo-bsc/lchan_rtp_fsm.c
I personally prefer the first one (I wrote that file ;) but the second one is good enough too in general.