[M] Change in osmo-bts[master]: common: Have PCU socket connection use osmo_wqueue

Attention is currently required from: laforge, pespin, fixeria. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31533 ) Change subject: common: Have PCU socket connection use osmo_wqueue ...................................................................... Patch Set 12: (3 comments) File src/common/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bts/+/31533/comment/6cdaea42_6d2fda0e PS6, Line 990: pcu_sock_close(state); My bad, thought I had already fixed this https://gerrit.osmocom.org/c/osmo-bts/+/31533/comment/b7a2bcff_018f4e63 PS6, Line 1106: rc = osmo_wqueue_enqueue(&state->upqueue, m); Hope this is alright now. I added a `return -1;` in case of other errors (previous code didn't return any other `errno` constants). `osmo_wqueue_bfd_cb` treats all other return values the same, however I would still rather return a `-1` just so the function itself returns negative values for all errors/looks more consistent that way File src/common/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bts/+/31533/comment/92ddcf1d_9fb0e15a PS9, Line 1112: rc = write(bfd->fd, msgb_data(msg), msgb_length(msg)); Yes, fixeria referred me to `osmo_wqueue_bfd_cb()`, which checks the returned value for some negative `errno` constants; in case of `rc == -EAGAIN`, it takes care of the readding of the `struct msgb` -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31533 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia6e61dda4b3cd4bba76e6acb7771d70335062fe1 Gerrit-Change-Number: 31533 Gerrit-PatchSet: 12 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Jun 2023 22:40:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment