14 Jan
2025
14 Jan
'25
5:07 p.m.
Attention is currently required from: laforge, pespin.
lynxis lazus has posted comments on this change by lynxis lazus. (
https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email )
Change subject: vlr: add PS support
......................................................................
Patch Set 5:
(5 comments)
File src/libvlr/vlr_lu_fsm.c:
https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/e49a35ab_34d6e3f1?usp… :
PS5, Line 357: int N; /*! counter of timeouts */
can we have something more descriptive like
num_timeouts?
I would like to have it in osmo_fsm.
The N is a common concept in GMM/MM timeouts.
Same as T for the timer name
https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/742df379_4ba9ba2e?usp… :
PS5, Line 569: static void vlr_lu_compl_fsm_reset_n(struct osmo_fsm_inst *fi, uint32_t
prev_state)
I'd really prefer have proper function names, one
for each state with its name plus "oenenter" appen […]
I'll copy the
same code in here then.
Maybe we move this reset N feature into the fsm, because I need it a couple of times.
https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/626869fb_627b2679?usp… :
PS5, Line 1437: static void lu_fsm_reset_n(struct osmo_fsm_inst *fi, uint32_t prev_state)
same, state name + "oneneter"
Acknowledged
https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/26ab7fc1_8e6f1dd1?usp… :
PS5, Line 1589: lfp->vlr->ops.tx_lu_rej(lfp->msc_conn_ref, gsm48_cause,
lfp->lu_type);
need to guard for null ptr func?
No, because the
initialize checks for null.
OSMO_ASSERT(ops->tx_lu_rej); in vlr_alloc()
https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/74913d92_630bc33e?usp… :
PS5, Line 1607: vlr->ops.tx_id_req(lfp->msc_conn_ref, GSM_MI_TYPE_IMSI);
need to guard for null ptr func?
No, because the
initialize checks for null.
OSMO_ASSERT(ops->tx_lu_rej); in vlr_alloc()
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ie9ffeb140c9d354b3a0f4822e2619f623235add0
Gerrit-Change-Number: 38490
Gerrit-PatchSet: 5
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 14 Jan 2025 16:07:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>