Attention is currently required from: laforge, pespin.

View Change

5 comments:

• File src/libvlr/vlr_lu_fsm.c:

  • Patch Set #5, Line 357: int N; /*! counter of timeouts */

    can we have something more descriptive like num_timeouts?

    I would like to have it in osmo_fsm.
    The N is a common concept in GMM/MM timeouts.
    Same as T for the timer name

  • Patch Set #5, Line 569: static void vlr_lu_compl_fsm_reset_n(struct osmo_fsm_inst *fi, uint32_t prev_state)

    I'd really prefer have proper function names, one for each state with its name plus "oenenter" appen […]

    I'll copy the same code in here then.
    Maybe we move this reset N feature into the fsm, because I need it a couple of times.

  • Patch Set #5, Line 1437: static void lu_fsm_reset_n(struct osmo_fsm_inst *fi, uint32_t prev_state)

    same, state name + "oneneter"

    Acknowledged

  • Patch Set #5, Line 1589: lfp->vlr->ops.tx_lu_rej(lfp->msc_conn_ref, gsm48_cause, lfp->lu_type);

    need to guard for null ptr func?

    No, because the initialize checks for null.

    OSMO_ASSERT(ops->tx_lu_rej); in vlr_alloc()

  • Patch Set #5, Line 1607: vlr->ops.tx_id_req(lfp->msc_conn_ref, GSM_MI_TYPE_IMSI);

    need to guard for null ptr func?

    No, because the initialize checks for null.

    OSMO_ASSERT(ops->tx_lu_rej); in vlr_alloc()

To view, visit change 38490. To unsubscribe, or for help writing mail filters, visit settings.