osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36089?usp=email )
Change subject: lib/gtp-kernel.c: initialize ret with 0 ......................................................................
lib/gtp-kernel.c: initialize ret with 0
Fix -Werror=maybe-uninitialize found in Pau's build env:
/home/pespin/dev/sysmocom/git/osmo-ggsn/lib/gtp-kernel.c: In function ‘gtp_kernel_tunnel_add’: /home/pespin/dev/sysmocom/git/osmo-ggsn/lib/gtp-kernel.c:111:13: error: ‘ret’ may be used uninitialized [-Werror=maybe-uninitialize] 111 | int ret; | ^~~ /home/pespin/dev/sysmocom/git/osmo-ggsn/lib/gtp-kernel.c: In function ‘gtp_kernel_tunnel_del’: /home/pespin/dev/sysmocom/git/osmo-ggsn/lib/gtp-kernel.c:167:13: error: ‘ret’ may be used uninitialized [-Werror=maybe-uninitialize] 167 | int ret; | ^~~
Fixes: b17fe7bf ("kernel-gtp: support IPv6 on inner layer") Change-Id: I19067ebe561d4c067b9ace7f5b201e15af6b342e --- M lib/gtp-kernel.c 1 file changed, 23 insertions(+), 2 deletions(-)
Approvals: Jenkins Builder: Verified dexter: Looks good to me, approved
diff --git a/lib/gtp-kernel.c b/lib/gtp-kernel.c index 9bfb380..3ad8424 100644 --- a/lib/gtp-kernel.c +++ b/lib/gtp-kernel.c @@ -108,7 +108,7 @@ struct in46_addr ms[2]; struct in46_addr sgsn; struct gtp_tunnel *t; - int ret; + int ret = 0;
pdp_debug(__func__, devname, pdp);
@@ -164,7 +164,7 @@ int ms_addr_count; struct in46_addr ms[2]; struct gtp_tunnel *t; - int ret; + int ret = 0;
pdp_debug(__func__, devname, pdp);