Attention is currently required from: pespin.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505?usp=email )
Change subject: HTTP_Adapter: allow body to be "omit"
......................................................................
Patch Set 2:
(2 comments)
File library/HTTP_Adapter.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505/comment/07586ff9_134a…
PS1, Line 85: msg.request := {
I'm not really liking this kind of functions you
are adding here and in previous messages, it differ […]
I am not agreeing here. we
are defining templates through functions in various places, see SGsAP_Templates.ttcn or
RANAP_Templates.ttcn. Its not done very often, but its also not an exotic practice.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505/comment/f131a978_1300…
PS1, Line 148: template charstring body := omit, template HTTPMessage exp :=
tr_HTTP_Resp2xx,
this is most probably a "template (omit)
charstring body".
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ifedc8c2a590835663d1ba0b08b1fe4d54bdd0fff
Gerrit-Change-Number: 36505
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 19 Apr 2024 11:55:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment