Jenkins Builder has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmocore/+/37797?usp=email )
Change subject: tests: add unit test for osmo_hr_sid_classify() ......................................................................
Patch Set 1:
(2 comments)
File tests/codec/codec_hr_sid_test.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17675): https://gerrit.osmocom.org/c/libosmocore/+/37797/comment/77a8dd44_a981716e?u... : PS1, Line 93: if (!isxdigit(*cp)) { suspect code indent for conditional statements (16, 32)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17675): https://gerrit.osmocom.org/c/libosmocore/+/37797/comment/7bef91b2_a8421292?u... : PS1, Line 139: for (lineno = 1; fgets(linebuf, sizeof linebuf, inf); lineno++) sizeof linebuf should be sizeof(linebuf)