[L] Change in libosmocore[master]: tests: add unit test for osmo_hr_sid_classify()

Jenkins Builder has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmocore/+/37797?usp=email ) Change subject: tests: add unit test for osmo_hr_sid_classify() ...................................................................... Patch Set 1: (2 comments) File tests/codec/codec_hr_sid_test.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17675): https://gerrit.osmocom.org/c/libosmocore/+/37797/comment/77a8dd44_a981716e?… : PS1, Line 93: if (!isxdigit(*cp)) { suspect code indent for conditional statements (16, 32) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17675): https://gerrit.osmocom.org/c/libosmocore/+/37797/comment/7bef91b2_a8421292?… : PS1, Line 139: for (lineno = 1; fgets(linebuf, sizeof linebuf, inf); lineno++) sizeof linebuf should be sizeof(linebuf) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37797?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9944bb7d49b6fe004d4bfc7a3f70cfdb03d62614 Gerrit-Change-Number: 37797 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Sun, 11 Aug 2024 17:23:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No