Attention is currently required from: jolly.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/35391?usp=email )
Change subject: Add LLC and HLC transcoding to MNCC transcoding functions
......................................................................
Patch Set 1:
(1 comment)
File src/gsm/gsm48_ie.c:
https://gerrit.osmocom.org/c/libosmocore/+/35391/comment/1dea33a5_90babfdf
PS1, Line 412: /*! Encode TS 04.08 High Layer compatibility IE (10.5.4.16) */
All this looks a bit overkill to me, having a struct
containing a len field and a buffer, and then c […]
AFAIU this is all really a len
and a buffer, so I don't really see the need for a specific structure to hold them.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/35391?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia6a2159ecf810a02f85b558026edf20b934567de
Gerrit-Change-Number: 35391
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Tue, 19 Dec 2023 14:33:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment