Attention is currently required from: fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/27866
)
Change subject: Move struct gsm_bts_paging_state to paging.h
......................................................................
Patch Set 2:
(1 comment)
File src/ipaccess/Makefile.am:
https://gerrit.osmocom.org/c/osmo-bsc/+/27866/comment/2722ad4b_52f6cd8e
PS2, Line 12: $(LIBOSMONETIF_CFLAGS) \
What if instead of <paging. […]
It's not
a pointer, bts needs to know the whole struct.
I think it's fine having all CFLAGS here. I think they should be actually added
everywhere, have some sort of libbsc.la CFLAGS and LIBS variables we can add everywhere.
But that's unrelated and can be done when we have more free time if we want.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/27866
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I8c058d308fc816828b5e6a86e7c5a1f629a2d7c4
Gerrit-Change-Number: 27866
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 21 Apr 2022 15:43:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment