Attention is currently required from: laforge, fixeria.
msuraev has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-sccp/+/29170 )
Change subject: SIGTRAN: add osmo_sccp_tx_disconn_data() helper
......................................................................
Patch Set 4:
(3 comments)
Patchset:
PS4:
Looks like changing default indent value wasn't applied to already opened buffers.
Let's see if restarting editor helps.
File src/sccp_helpers.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/29170/comment/3b93a664_fe26a587
PS4, Line 196: int osmo_sccp_tx_disconn_data(struct osmo_sccp_user *scu, uint32_t
conn_id,
Weird misalignment, still.
Done
https://gerrit.osmocom.org/c/libosmo-sccp/+/29170/comment/5f1dc806_ccf23f85
PS4, Line 230: int osmo_sccp_tx_disconn(struct osmo_sccp_user *scu, uint32_t conn_id,
Weird misalignment, still.
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-sccp/+/29170
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I92ae22d2cab5863245fba3d904a300055fda34fe
Gerrit-Change-Number: 29170
Gerrit-PatchSet: 4
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 22 Aug 2022 13:34:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment