Attention is currently required from: neels.
falconia has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/29973 )
Change subject: msc_a: send MNCC_RTP_CONNECT in call waiting scenarios
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Cool, I never considered / tried Call Waiting before.
[…]
@neels - thank you for taking the time to review my silly trivial patch! Please
note that this patch is only a band-aid and NOT a proper solution - the band-aid allowed
call waiting to work in the basic tests I did back then, but it comes nowhere close to a
correct handling of all scenarios and corner cases. The only reason I submitted this patch
to Gerrit all those months ago was upon urging from @fixeria, who told me something along
the lines of "better to have a partial fix in the code than none at all".
Regarding logs and ladder diagrams - point taken and noted. I will retest the patch and
capture those logs when I find some time to switch my attention back to OsmoMSC, which I
haven't touched in all these months.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-msc/+/29973
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ibb62cb3c154b99769b2dfe708f73c20e8b632f5d
Gerrit-Change-Number: 29973
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 23 Jun 2023 07:50:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: comment