Attention is currently required from: dexter, fixeria, laforge.
neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39742?usp=email )
Change subject: personalization: refactor ConfigurableParameter, Iccid, Imsi ......................................................................
Patch Set 14:
(1 comment)
File pySim/esim/saip/personalization.py:
https://gerrit.osmocom.org/c/pysim/+/39742/comment/3aed4a5e_4936a1db?usp=ema... : PS13, Line 50: r"""Base class representing a part of the eSIM profile that is configurable during the
abc has no purpose and it doesn't work. […]
I would have liked that my opinion on mini minor aspects would be heard as a useful choice that has been made to save time, and not ridden out over and over until i have to, again, completely give up my entire point -- mind you in disapproval.
I will adjust the patch now, which means I will read up on how to use abstract decorators properly, again, to probably conclude, again, that it is not solving any problem of remote relevance to this branch. I will remember, again, that I have never seen it being used in any RL lib or app anywhere. Mixins, inheritance: yes; ABC: no. I have seen a fair share of python and seeing ABC here did not help me, but confused me into ivestiating what is so different here that it needs ABC; turns out, nothing. So why am I adding this? There is for many months now *objectively* no reason to spend any time on this, at all. I will still add it back despite all this, and I am not very happy about it.
related: I thought about my is_abstract flag and I think it is a misnomer and still the wrong approach. I will comment about that on the patch adding the is_abstract flag...