Attention is currently required from: lynxis lazus.
neels has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38489?usp=email )
Change subject: vlr: when receiving imsi detach, purge the subscriber towards HLR ......................................................................
Patch Set 5: Code-Review+1
(1 comment)
File src/libvlr/vlr.c:
https://gerrit.osmocom.org/c/osmo-msc/+/38489/comment/ad95ea64_87212864?usp=... : PS5, Line 1523: rc |= vlr_subscr_detach(vsub); (for me personally, '|=' on int type indicates some sort of bitmask logic; here it seems to be boolean logic. so i tend to want to look up what is the bitmask. If it were explicitly boolean, it would be a bit clearer, cosmetically. Returning a | of return code "enum values" forms meaningless enum values, right?)