Attention is currently required from: lynxis lazus.

Patch set 5:Code-Review +1

View Change

1 comment:

• File src/libvlr/vlr.c:

  • Patch Set #5, Line 1523: rc |= vlr_subscr_detach(vsub);

    (for me personally, '|=' on int type indicates some sort of bitmask logic; here it seems to be boolean logic. so i tend to want to look up what is the bitmask. If it were explicitly boolean, it would be a bit clearer, cosmetically. Returning a | of return code "enum values" forms meaningless enum values, right?)

To view, visit change 38489. To unsubscribe, or for help writing mail filters, visit settings.