[M] Change in libosmo-sigtran[master]: sigtran: Make osmo_ss7_asp struct private

Attention is currently required from: laforge, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38645?usp=email ) Change subject: sigtran: Make osmo_ss7_asp struct private ...................................................................... Patch Set 8: (1 comment) File src/ipa.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/38645/comment/c14fba7c_7841d… : PS3, Line 50: #i Since they are in the same directory as the source file, hence included with "" it already becomes clear it's a private header imho. I didn't "start" this trend here, I just followed what was already there (see for instance how I did include/osmocom/gprs/*/*_private.h instead in libosmo-gprs when I wrote most of it). That being said, I have no strong opinion, so if you really think another option is better, I'm fine to easily move all headers at the end in a follow-up commit when this gets merged, as suggested by osmith. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38645?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I5839b4dd04468af20d1836386dcc722e7a83ac5f Gerrit-Change-Number: 38645 Gerrit-PatchSet: 8 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 11 Nov 2024 15:06:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>