8 Jun
2023
8 Jun
'23
5:01 p.m.
Attention is currently required from: arehbein, pespin, daniel.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33194 )
Change subject: examples: Use osmo_io in {ipa-,}stream-{client,server} ......................................................................
Patch Set 4:
(1 comment)
File examples/ipa-stream-client.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/33194/comment/f5ca0579_63a725b4 PS4, Line 176: osmo_stream_cli_set_iofd_read_cb(conn, read_cb);
I don't really like polluting the APIs in osmo_stream with implementation specific "iofd" names. […]
I tend to agree with pau.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33194
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I97a9979199c816686b32080534627f6f033e009e
Gerrit-Change-Number: 33194
Gerrit-PatchSet: 4
Gerrit-Owner: arehbein arehbein@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: daniel dwillmann@sysmocom.de
Gerrit-CC: laforge laforge@osmocom.org
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: arehbein arehbein@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: daniel dwillmann@sysmocom.de
Gerrit-Comment-Date: Thu, 08 Jun 2023 15:01:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin pespin@sysmocom.de
Gerrit-MessageType: comment