Attention is currently required from: fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/27938 )
Change subject: coding: fix comments for detect_afs_sid_{first,update,onset}
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/coding/gsm0503_amr_dtx.c:
https://gerrit.osmocom.org/c/libosmocore/+/27938/comment/e14873b9_09560f15
PS2, Line 179: static bool detect_afs_onset(int *n_errors, int *n_bits_total, const ubit_t
* ubits)
shouldn't this function be renamed to detect_afs_sid_onset to be like the others?
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/27938
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I42edc3caee09c1a4bebecc41e8be46914dc7f8ef
Gerrit-Change-Number: 27938
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 26 Apr 2022 09:44:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment