Attention is currently required from: laforge.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/30148 )
Change subject: osmux: Rework log formatting when replaying detected RTP gaps
......................................................................
Patch Set 1:
(1 comment)
File src/osmux_input.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/30148/comment/94d0dde8_5f58a98d
PS1, Line 366: d
did you consider sequence wrap-around here? What if
for example last_seq == 65535 and cur_seq == 0 o […]
Indeed I have my doubts this
code is 100% correct when wrap around is in place. I started looking into exact this
already before submitting this patch. That's why I wrote in the commit log that flaws
will be fixed in follow up patches.
I submitted this patch because it is actually not really changing the arithmetic here,
only rearranging a few parts to have a more meaningful log line.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-netif/+/30148
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I5fd64acf7bc1e53efae0674d0c906d1255a9bbf6
Gerrit-Change-Number: 30148
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 15 Nov 2022 11:41:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment