8 Jun
2023
8 Jun
'23
5:46 p.m.
Attention is currently required from: arehbein, laforge, daniel.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33193 )
Change subject: Add osmo_io support to osmo_stream_cli and osmo_stream_srv ......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS5:
Internally, the osmo_stream code calls the read_cb() if non NULL, or/and the iofd_read_cb() if not […]
Fine with your proposal, but I'd remove "iofd" and use "2" or alike, I'd really avoid naming "iofd" since there's anyway nothing "iofd" specific struct from the interface point of view?
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33193
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I2f52c7107c392b6f4b0bf2a84f8c873c084a200c
Gerrit-Change-Number: 33193
Gerrit-PatchSet: 6
Gerrit-Owner: arehbein arehbein@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-CC: daniel dwillmann@sysmocom.de
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: arehbein arehbein@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: daniel dwillmann@sysmocom.de
Gerrit-Comment-Date: Thu, 08 Jun 2023 15:46:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge laforge@osmocom.org
Comment-In-Reply-To: pespin pespin@sysmocom.de
Comment-In-Reply-To: daniel dwillmann@sysmocom.de
Gerrit-MessageType: comment