[XL] Change in osmo-sgsn[master]: add libvlr based on MSC commit 25362cc295036a4671804db9003c3d22a88309d2

17 Feb 2025

Attention is currently required from: lynxis lazus.

Jenkins Builder has posted comments on this change by lynxis lazus. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email )

Change subject: add libvlr based on MSC commit 25362cc295036a4671804db9003c3d22a88309d2
......................................................................

Patch Set 4:

(32 comments)

File include/osmocom/vlr/vlr.h:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/52391b8d_92ed7ae0?us… :
PS4, Line 121: 	long long unsigned int id;
type 'long long unsigned int' should be specified in [[un]signed]
[short|int|long|long long] order

File src/libvlr/vlr.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/55fb2ee1_1d8b85bf?us… :
PS4, Line 238: 		OSMO_STRBUF_PRINTF(sb, "%sMSISDN-%s", present? ":" :
"", vsub->msisdn);
spaces required around that '?' (ctx:VxW)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/d326dd31_9b4a7170?us… :
PS4, Line 242: 		OSMO_STRBUF_PRINTF(sb, "%sTMSI-0x%08X", present? ":"
: "", vsub->tmsi);
spaces required around that '?' (ctx:VxW)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/3994a3dd_33e74d01?us… :
PS4, Line 246: 		OSMO_STRBUF_PRINTF(sb, "%sTMSInew-0x%08X", present?
":" : "", vsub->tmsi_new);
spaces required around that '?' (ctx:VxW)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/3f3d8959_6aedfe0a?us… :
PS4, Line 258: 	char *name = (char*)vlr_subscr_name(vsub);
"(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/7e30ea63_9bb844cc?us… :
PS4, Line 263: 		strcpy(name + maxlen - 2, "..");
Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY()

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/2518d7b9_b3e1294c?us… :
PS4, Line 380: 		vlr_subscr_name(vsub), (e->count - old_use_count) > 0?
"+" : "-", e->use,
spaces required around that '?' (ctx:VxW)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/f7712610_a462c2e5?us… :
PS4, Line 705: 	         osmo_plmn_name(&vsub->sgs.last_eutran_plmn) :
code indent should use tabs where possible

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/a1ccc9b4_f7b614ef?us… :
PS4, Line 810: 	struct sgsn_subscriber_pdp_data* pdata;
"foo* bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/604b34d8_452aef6a?us… :
PS4, Line 1447: 						      VLR_AUTH_E_MS_ID_IMSI, (void*)mi->imsi);
"(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/cb65cf68_a104c3af?us… :
PS4, Line 1455: 			return osmo_fsm_inst_dispatch(vsub->lu_fsm, VLR_ULA_E_ID_IMSI,
(void*)mi->imsi);
"(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/fed84584_d3253053?us… :
PS4, Line 1457: 			return osmo_fsm_inst_dispatch(vsub->lu_fsm, VLR_ULA_E_ID_IMEI,
(void*)mi->imei);
"(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/cb74617c_82d46ab4?us… :
PS4, Line 1459: 			return osmo_fsm_inst_dispatch(vsub->lu_fsm, VLR_ULA_E_ID_IMEISV,
(void*)mi->imeisv);
"(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/9ef01375_413214cc?us… :
PS4, Line 1716: 	struct vlr_subscr **fsub =
(void*)&target->filter_data[LOG_FLT_VLR_SUBSCR];
"(foo*)" should be "(foo *)"

File src/libvlr/vlr_access_req_fsm.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/32860735_b6dc89d4?us… :
PS4, Line 111: 	return par->result? gsm48_reject_value_name(par->result) :
"PASSED";
spaces required around that '?' (ctx:VxW)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/ef077dbc_d4354d48?us… :
PS4, Line 415: 	} else {
else is not generally useful after a break or return

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/26b9e142_e81786c2?us… :
PS4, Line 421: 		} else {
else is not generally useful after a break or return

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/c2dd222b_09d9c2ce?us… :
PS4, Line 496: 		result = *(enum vlr_ciph_result_cause*)data;
"(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/3b6befe6_e4b7f222?us… :
PS4, Line 791: 		.in_event_mask = ,
space prohibited before that ',' (ctx:WxE)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/e74bdc89_a1ed9bd6?us… :
PS4, Line 798: 		.in_event_mask = ,
space prohibited before that ',' (ctx:WxE)

File src/libvlr/vlr_auth_fsm.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/2079eb14_eefb24df?us… :
PS4, Line 199: 			 res_len, (res_len == vec->res_len)? "valid" :
"INVALID on UTRAN");
spaces required around that '?' (ctx:VxW)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/133d6d13_5891c606?us… :
PS4, Line 216: 	} else {
else is not generally useful after a break or return

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/28d3e5f2_fe2e0e76?us… :
PS4, Line 543: 			strncpy(vsub->imsi, mi_string, sizeof(vsub->imsi));
Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY()

File src/libvlr/vlr_lu_fsm.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/386a49c3_344b174b?us… :
PS4, Line 160: 	return (struct vlr_subscr*)fi->priv;
"(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/0aa11f50_d453a0e0?us… :
PS4, Line 272: 	return (struct vlr_subscr*)fi->priv;
"(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/b4076c54_38f00909?us… :
PS4, Line 667: 	return (struct lu_compl_vlr_priv*)fi->priv;
"(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/41f47252_eb22a48e?us… :
PS4, Line 1282: 		result = *(enum vlr_ciph_result_cause*)data;
"(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/665ce432_87629047?us… :
PS4, Line 1404: 			cause = *(uint8_t*)data;
"(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/6f9b9090_635e60dd?us… :
PS4, Line 1436: 			cause = *(uint8_t*)data;
"(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/fa6e04b2_31913578?us… :
PS4, Line 1643: 	return (struct lu_fsm_priv*)fi->priv;
"(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/b2d625a4_56772006?us… :
PS4, Line 1691: 		strncpy(lfp->imsi, imsi, sizeof(lfp->imsi)-1);
Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY()

File src/libvlr/vlr_sgs.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577):
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/44dd7f87_1fecc707?us… :
PS4, Line 324: }
void function return statements are not generally useful

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I221114e00e6f338a75ae0dd7ac285e262b23635d
Gerrit-Change-Number: 39560
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus &lt;lynxis(a)fe80.eu&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: lynxis lazus &lt;lynxis(a)fe80.eu&gt;
Gerrit-Comment-Date: Mon, 17 Feb 2025 22:17:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

2025

2024

2023

2022

[XL] Change in osmo-sgsn[master]: add libvlr based on MSC commit 25362cc295036a4671804db9003c3d22a88309d2