Attention is currently required from: neels, pespin, msuraev.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-sccp/+/31295 )
Change subject: SS7: do not attempt transfer if AS is down
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
File src/osmo_ss7.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/31295/comment/4b4ad1c2_72a8040e
PS2, Line 1151: if (!as->fi)
So now we enter the debate whether an unexisting as is
down or not. […]
Ack
File src/osmo_ss7_hmrt.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/31295/comment/5eaa6c76_5aa329c0
PS2, Line 234: return -ENETDOWN;
I'm fine with ENETDOWN, to me that's
what's being cecked.
neels point-of-view is from the IP/socket perspective,
while pespin is looking at it from the SS7 perspective. I also think NETDOWN is fine.
From the SS7 point of view, the SCTP assocation is the underlying physical medium.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-sccp/+/31295
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I0d5f3b6265e7fdaa79e32fbc30f829ef79e7dad1
Gerrit-Change-Number: 31295
Gerrit-PatchSet: 2
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 14 Feb 2023 10:14:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment