17 Feb
2025
17 Feb
'25
10:16 a.m.
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39556?usp=email )
Change subject: s1ap_proxy: catch exceptions in handle_pdu/2 ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/s1ap_proxy.erl:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39556/comment/5a533e3a_2413b... : PS1, Line 240: {{forward, OrigData}, S0} %% XXX: proxy as-is or drop? Ideally once processing of packets is split into multiple steps (parsing, processing, transmitting), the best would be to look at the parsed message type and answer accordingly eg. rejecting the request?
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39556?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Ib1e6674f5b85557866c7beaea710ea903e4eeaca
Gerrit-Change-Number: 39556
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Mon, 17 Feb 2025 10:16:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes