Change in osmo-bsc-nat[master]: Refactor subscr_conn_get_next_id

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27711 ) Change subject: Refactor subscr_conn_get_next_id ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/osmo-bsc-nat/subscr_conn.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27711/comment/40e35b2a_478ab827 PS2, Line 31: { I think it makes much more sense to have 3 separate functions, other than having a 1 more complex function with a more complex lookup loop, which can potentially iterate 2^32 times. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27711 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I77b0ef33f94c401d24f38eb8d79e1007234e0ab4 Gerrit-Change-Number: 27711 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 08 Apr 2022 17:03:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment