Change in libosmo-abis[master]: Add setting of Sa bits to misdn driver

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31034 ) Change subject: Add setting of Sa bits to misdn driver ...................................................................... Patch Set 3: (4 comments) Patchset: PS3: I think it makes more sense if you join this commit with the one adding the function pointer in the struct (header file). File src/input/misdn.c: https://gerrit.osmocom.org/c/libosmo-abis/+/31034/comment/1084eeaf_a2841b09 PS3, Line 300: struct e1inp_ts *e1i_ts = &line->ts[16-1]; what's this 16-1? isn't there some descriptivie define for it? https://gerrit.osmocom.org/c/libosmo-abis/+/31034/comment/523d29ce_2b35036c PS3, Line 302: uint8_t buffer[sizeof(struct mISDNhead) + sizeof(int)]; uint32_t? https://gerrit.osmocom.org/c/libosmo-abis/+/31034/comment/7c6b13df_1aa9a140 PS3, Line 304: int *info = (int *)(buffer + sizeof(struct mISDNhead)); uint32_t? -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31034 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I54205a2534a7638cc071888d853f9d6d312dc9f0 Gerrit-Change-Number: 31034 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 23 Jan 2023 10:13:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment