Attention is currently required from: fixeria.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/37684?usp=email )
Change subject: pySim-shell: Support hexadecimal ADM pin in 'verify_adm'
......................................................................
Patch Set 1:
(1 comment)
File pySim-shell.py:
https://gerrit.osmocom.org/c/pysim/+/37684/comment/71c16a30_c5bd099e
PS1, Line 829: '--pin-is-hex'
maybe add short `-H` for convenience?
cmd2 has
tab completion... I'd rather keep expressive names.
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/37684?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I4191ed79ebe7869d8411d280a32ac2d4bbc210e3
Gerrit-Change-Number: 37684
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Aug 2024 13:19:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment