Attention is currently required from: dexter, neels.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35212?usp=email )
Change subject: ecu: force alignment of member data in struct osmo_ecu_state ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: I'm not sure this is entirely fixing the issue. Not sure that the fact that a previous field is aligned means the next one is actually aligned. And aligned to what... because bigger structs may need bigger alignment? or is 4-8 byte alignment enough?
IMHO whoever does a private implementation of that struct, should have a private struct containing the public one, as in a subclass, and then find out its subclass pointer (private one) based on the offset of the public one.