Jenkins Builder has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/29473 )
Change subject: add gsm0808_amr_modes_from_cfg
......................................................................
Patch Set 1:
(20 comments)
File src/gsm/gsm0808.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-libosmocore-lint-509):
https://gerrit.osmocom.org/c/libosmocore/+/29473/comment/57243faa_a832caed
PS1, Line 2006: [ 0] = B(4_75),
space prohibited after that open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-libosmocore-lint-509):
https://gerrit.osmocom.org/c/libosmocore/+/29473/comment/1366b73c_5a37b1d7
PS1, Line 2007: [ 1] = B(4_75) | B(5_90) | B(7_40),
space prohibited after that open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-libosmocore-lint-509):
https://gerrit.osmocom.org/c/libosmocore/+/29473/comment/313dfbf0_5601bbfc
PS1, Line 2008: [ 2] = B(5_90),
space prohibited after that open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-libosmocore-lint-509):
https://gerrit.osmocom.org/c/libosmocore/+/29473/comment/9b80945f_17a1253d
PS1, Line 2009: [ 3] = B(6_70),
space prohibited after that open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-libosmocore-lint-509):
https://gerrit.osmocom.org/c/libosmocore/+/29473/comment/a7b1cb1e_d58206aa
PS1, Line 2010: [ 4] = B(7_40),
space prohibited after that open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-libosmocore-lint-509):
https://gerrit.osmocom.org/c/libosmocore/+/29473/comment/7886184e_a2d57c8d
PS1, Line 2011: [ 5] = B(7_95),
space prohibited after that open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-libosmocore-lint-509):
https://gerrit.osmocom.org/c/libosmocore/+/29473/comment/0f495742_656d237e
PS1, Line 2012: [ 6] = 0,
space prohibited after that open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-libosmocore-lint-509):
https://gerrit.osmocom.org/c/libosmocore/+/29473/comment/ec2f9441_6f1b2757
PS1, Line 2013: [ 7] = 0,
space prohibited after that open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-libosmocore-lint-509):
https://gerrit.osmocom.org/c/libosmocore/+/29473/comment/841ef9da_23475e6c
PS1, Line 2015: [ 8] = B(4_75) | B(5_90),
space prohibited after that open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-libosmocore-lint-509):
https://gerrit.osmocom.org/c/libosmocore/+/29473/comment/20eeceaa_ee4af5a1
PS1, Line 2016: [ 9] = B(4_75) | B(5_90) | B(6_70),
space prohibited after that open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-libosmocore-lint-509):
https://gerrit.osmocom.org/c/libosmocore/+/29473/comment/5d213229_52bdff2c
PS1, Line 2027: [ 0] = B(4_75),
space prohibited after that open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-libosmocore-lint-509):
https://gerrit.osmocom.org/c/libosmocore/+/29473/comment/dae4ab19_2669b899
PS1, Line 2028: [ 1] = B(4_75) | B(5_90) | B(7_40)
| B(12_2),
space prohibited after that open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-libosmocore-lint-509):
https://gerrit.osmocom.org/c/libosmocore/+/29473/comment/16480384_d52e3450
PS1, Line 2029: [ 2] = B(5_90),
space prohibited after that open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-libosmocore-lint-509):
https://gerrit.osmocom.org/c/libosmocore/+/29473/comment/ad966da8_48194508
PS1, Line 2030: [ 3] = B(6_70),
space prohibited after that open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-libosmocore-lint-509):
https://gerrit.osmocom.org/c/libosmocore/+/29473/comment/519c3762_0eb7e840
PS1, Line 2031: [ 4] = B(7_40),
space prohibited after that open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-libosmocore-lint-509):
https://gerrit.osmocom.org/c/libosmocore/+/29473/comment/222930af_4590af2d
PS1, Line 2032: [ 5] = B(7_95),
space prohibited after that open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-libosmocore-lint-509):
https://gerrit.osmocom.org/c/libosmocore/+/29473/comment/95f8b42b_6ddd0b9f
PS1, Line 2033: [ 6] = B(10_2),
space prohibited after that open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-libosmocore-lint-509):
https://gerrit.osmocom.org/c/libosmocore/+/29473/comment/996e53a6_6b48301f
PS1, Line 2034: [ 7] = B(12_2),
space prohibited after that open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-libosmocore-lint-509):
https://gerrit.osmocom.org/c/libosmocore/+/29473/comment/36ab1e68_b4cdf022
PS1, Line 2036: [ 8] = B(4_75) | B(5_90),
space prohibited after that open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-libosmocore-lint-509):
https://gerrit.osmocom.org/c/libosmocore/+/29473/comment/c6a918bd_41ed2735
PS1, Line 2037: [ 9] = B(4_75) | B(5_90) | B(6_70),
space prohibited after that open square bracket '['
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/29473
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icef7dd626d3d4641c66b8dd87e2047fc0ab547d1
Gerrit-Change-Number: 29473
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Fri, 23 Sep 2022 16:53:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment