10 May
2024
10 May
'24
10:33 a.m.
Attention is currently required from: pespin.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36755?usp=email )
Change subject: asterisk: Implement AMI_Adapter using IPL4 instead of TELNET
......................................................................
Patch Set 3:
(2 comments)
File asterisk/AMI_Functions.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36755/comment/931c0bd2_5625…
PS3, Line 260: /* TEXT Enc/dec is not happy with values containing "; ", get
rid of them:
: * "AppData: 5,0502: Call pjsip endpoint from 0501\r\n" */
: var integer pos := f_strstr(patched_txt, "AppData: ", 0);
: if (pos >= 0) {
: var integer pos_end := f_strstr(patched_txt, "\r\n", pos) +
lengthof("\r\n");
: var charstring to_remove := substr(patched_txt, pos, pos_end - pos);
: patched_txt := f_str_replace(patched_txt, to_remove, "");
: }
I don't understand what this does. The comment mentions "; ", but it is not
in the example in the comment or code below. From the code it seems more like removing
\r\n in a string that looks like "Appdata:\r\nvalue-of-appdata-here\r\n"?
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36755/comment/eb409d8a_e3c6…
PS3, Line 480: log("AMI_Msg decoded: ", msg);
add some sort of assert / check at the end, that the decode lead to the expected result?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36755?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Icaf2860c1dd4befa4498f0d176cfadf26cfa8d1d
Gerrit-Change-Number: 36755
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 10 May 2024 08:33:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment